Add cancellable and execution limit params #1136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the Common Query Parameters related to query cancellation and execution limits to
Select
. We only hadtimeAllowed
andcpuAllowed
so far, I've moved those over fromAbstractQuery
as they only apply to search anyway. (Only deprecatedtimeAllowed
,cpuAllowed
support wasn't released yet.) Proactively includedmemAllowed
that will be available in Solr 9.8.Tried to stick to the order of the ref guide for the code and tests. I find that the easiest way to cross-reference which parameters we're still missing support for.