Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancellable and execution limit params #1136

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

thomascorthals
Copy link
Member

I've added the Common Query Parameters related to query cancellation and execution limits to Select. We only had timeAllowed and cpuAllowed so far, I've moved those over from AbstractQuery as they only apply to search anyway. (Only deprecated timeAllowed, cpuAllowed support wasn't released yet.) Proactively included memAllowed that will be available in Solr 9.8.

Tried to stick to the order of the ref guide for the code and tests. I find that the easiest way to cross-reference which parameters we're still missing support for.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (9cdf3dd) to head (81ca96c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   97.75%   97.76%   +0.01%     
==========================================
  Files         400      400              
  Lines       10524    10575      +51     
==========================================
+ Hits        10288    10339      +51     
  Misses        236      236              
Flag Coverage Δ
unittests 97.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkalkbrenner mkalkbrenner merged commit 6bdb4cd into solariumphp:master Nov 27, 2024
34 checks passed
@thomascorthals thomascorthals deleted the exec-limits branch November 27, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants