Issue #1095: Spatial component should use floats for distance.

[wu-edward]

No description provided.

[wu-edward]

Addresses #1095

[thomascorthals]

Minor nitpick: maybe update these tests to use floats? That should prevent the unlikely regression of accidentally reverting to ints.

solarium/tests/Component/SpatialTest.php

Line 21 in 376ad9f

public function testConfigMode()

solarium/tests/Component/SpatialTest.php

Line 65 in 376ad9f

public function testSetAndGetDistance()

solarium/tests/Component/RequestBuilder/SpatialTest.php

Line 12 in 376ad9f

public function testBuildComponent()

[wu-edward]

Minor nitpick: maybe update these tests to use floats? That should prevent the unlikely regression of accidentally reverting to ints.

solarium/tests/Component/SpatialTest.php

Line 21 in 376ad9f

public function testConfigMode()

solarium/tests/Component/SpatialTest.php

Line 65 in 376ad9f

public function testSetAndGetDistance()

solarium/tests/Component/RequestBuilder/SpatialTest.php

Line 12 in 376ad9f

public function testBuildComponent()

Thanks for the review. Pushed a commit with updated tests.

[thomascorthals]

@wu-edward I often forget this myself for small fixes like this, but it's worth mentioning in the CHANGELOG too. No longer rounding to an integer distance will influence results.

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (52e5623) 97.49% compared to head (5e19974) 97.49%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1096   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         389      389           
  Lines       10148    10148           
=======================================
  Hits         9894     9894           
  Misses        254      254           

Flag	Coverage Δ
unittests	97.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/Component/Spatial.php	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wu-edward]

@wu-edward I often forget this myself for small fixes like this, but it's worth mentioning in the CHANGELOG too. No longer rounding to an integer distance will influence results.

CHANGELOG updated