Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokens/escrow/steel #278

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add tokens/escrow/steel #278

wants to merge 7 commits into from

Conversation

Ovodo
Copy link

@Ovodo Ovodo commented Oct 29, 2024 •
edited
Loading

  • utilized mostly methods from the steel framework for instruction handlers
  • ensured code works out of the box
  • added more edge cases for testing
  • added tests using native rust and steel sdk
  • added tests using bankrun
  • ran pnpm fix

@heyAyushh heyAyushh added contribute:steel Adds program example using steel framework. escrow tokens/escrow labels Nov 6, 2024
heyAyushh
heyAyushh reviewed Dec 1, 2024
View reviewed changes
Copy link
Contributor

@heyAyushh heyAyushh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ovodo LGTM, please merge main branch, run pnpm fix to fix style and lint issues in ts and run cargo clippy and cargo fmt in steel projects for the same for rust files.

@Ovodo
Copy link
Author

Ovodo commented Dec 1, 2024

Okay will do

@Ovodo
Copy link
Author

Ovodo commented Dec 1, 2024

Already updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyAyushh heyAyushh heyAyushh left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
contribute:steel Adds program example using steel framework. escrow tokens/escrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ovodo @heyAyushh