Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basics/hello-solana/poseidon #247

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add basics/hello-solana/poseidon #247

wants to merge 8 commits into from

Conversation

Leeyah-123
Copy link

No description provided.

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. hello-solana basics/hello-solana labels Nov 15, 2024
heyAyushh
heyAyushh reviewed Nov 24, 2024
View reviewed changes
Copy link
Contributor

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@Leeyah-123 Leeyah-123 requested a review from heyAyushh December 5, 2024 11:45
@Leeyah-123
Copy link
Author

Leeyah-123 commented Dec 5, 2024 •
edited
Loading

@heyAyushh Thanks for the review. I have made the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyAyushh heyAyushh Awaiting requested review from heyAyushh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
contribute:poseidon Adds a poseidon example contribution to the repository. hello-solana basics/hello-solana
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leeyah-123 @heyAyushh