Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ignoring spl2.0 dependency issue #109

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

heyAyushh
Copy link
Contributor

@heyAyushh heyAyushh commented Aug 2, 2024

Refactor Anchor Action and Solana Action

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

# not building
oracles/pyth/anchor

# avm broke hence can't build
# can't use anchor.toml [toolchain] with stable rust
# update these programs to use latest anchor version to fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# update these programs to use latest anchor version to fix
# TODO: update these programs to use latest anchor version to fix

Add a TODO for this, people sometimes search for TODO and fix them for you!

Comment on lines 21 to 22
# not building
oracles/pyth/anchor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# not building
oracles/pyth/anchor
# not building. TODO: fix.
oracles/pyth/anchor

@jacobcreech jacobcreech merged commit 6d134a7 into solana-developers:main Aug 8, 2024
17 checks passed
@heyAyushh heyAyushh changed the title Skip ignoring spl2.0 dependency issue (#2) Skip ignoring spl2.0 dependency issue Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants