Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title function doesn't support incoming strings containing a section of uppercase letters #440

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shiliuzi8686
Copy link

Description

title function doesn't support incoming strings containing a section of uppercase letters
image

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #439

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 9:21am

@shiliuzi8686
Copy link
Author

shiliuzi8686 commented Dec 10, 2024

I seem to have misinterpreted the meaning of this issue,

The practical effect so far is:
title('ABC') -> A B C
title('WCBA_active') ==> W C B A Active

I think it should be:
title('ABC') -> Abc
title('WCBA_active') ==> Wcba Active

But this issue thinks that:
title('ABC') -> ABC
title('WCBA_active') ==> WCBA Active

I think this needs to be at the discretion of the program manager, and then I'll make the next change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant