Implement ByteBuffers

[tarcieri]

This is @UpeksheJay's GSoC work

[tarcieri]

Not sure this is useful versus always acting on multiple bytes

[tarcieri]

Some suggestions on next steps:

1. Write tests! 😄
2. Write a pure Ruby implementation of the same API that also passes the tests and has the same semantics
3. Support for doing I/O operations directly on the ByteBuffer

[UpeksheJay]

Thanks Tony, I will follow those suggestions. 👍

[Upekshe]

@tarcieri Since " this API should be used for adding strings to ByteBuffers". I guess I can avoid the methods such as putAbyte and putInt(), ... and just think about the Strings. In the java API they support all sorts of data types. That is why I intended to include a method such as putAbyte. Anyway I would have a generalize put method ("<<") that can handle Strings, Numbers and other byteArrays without a problem :) . I guess that would be better.

[Upekshe]

@UpeksheJay is also me 😃

[tarcieri]

Remove this line and it should fix the build. JRuby 1.7 is very old and we probably don't need to support it anymore.

[tarcieri]

@UpeksheJay I just squashed your commits and also did some formatting cleanups on the C code (hard tabs -> 4 spaces, and some cleanups to brace formatting for if statements)

If this passes the tests and looks good to you, you'll want to do the following on your local copy (provided your local branch is also named bytebuffers):

$ git branch -D bytebuffers
$ git fetch
$ git checkout bytebuffers

That should blow away your local branch and use the upstream one from GitHub. If you do git show, you should see:

commit 4754d518682be1ede973de8bb7e67053bc8b3f2e
Author: UpeksheJay <[email protected]>
Date:   Sun Sep 4 11:07:55 2016 -0700

    ByteBuffers GSoC project

Let me know if that all sounds good.

[kares]

you probably want to have the exception type consistent across implementations, currently it is a different kind (based on backend used) : this could be improved to do rb_raise(rb_eTypeError, "not a valid input") like in MRI : throw new runtime.newTypeError("not a valid input")

[Upekshe]

Hi Tony, I will add new commit to bytebuffers branch with fixes for the issues pointed out by Kares. BTW, thnks Kares for the reviews 👍

[tarcieri]

Thanks @Upekshe for your contributions!