-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to join several rooms at once #2879
Conversation
@darrachequesne |
@darrachequesne . "socket.io": "^1.7.3", But that feature still not working. Code here: socket.join(['tungns1', 'tungns2', 'tungns3']); // client join But i changed : for(var i = 1, length1 = 4; i < length1; i++){
console.log('tungns'+i);
socket.join('tungns'+i);
} Then working. |
Yep, it's not released yet. |
@darrachequesne - since we have now ability to join multiple rooms at once, shouldn't be nice to have the same for sending a message to multiple rooms?
but I guess something like:
will be more handy. |
@angel1st great idea! Could you please open a PR for that? |
The kind of change this PR does introduce
New behaviour
Enable the following:
socket.join(['room1', 'room2']);
Closes #2466, closes #2877