The mother of all semicolon fixes #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed; req now accepts a response parser
…the frame parser.
… opts being optional. Changed; parser override only for paths that include transports. Changed; style.
Changed; style
…t to message another socket, or group of sockets).
…he engine requirement or it will not work with future node versions.
…ket.io-node` requires as that is the name according to the package.json. Also updated the styling to fancy pancy HTML highlighting
Added log accessor to Socket
…clearing and disconnection handling.
…an empty endpoint and advice.
Added "clearPollTimeout" method
…anually. Changed; perform error handling for Store#isHandshaken. Added; handle manual disconnect urls. Changed; make sure to initialize a socket for all namespaces when a client connects. Changed; delegate packet handling to the appropriate SocketNamespace. Changed; cache regular expression for checkRequest method.
…s overridden. Changed; keep track of disconnected state and ACK callbacks. Added; make sure to emit the `disconnect` event. Removed readyState handling, shouldn't be part of the public API.
Added SocketNamespace#socket to retrieve/create Sockets. Added packet handling.
Added Transport#onSocketConnect interface. Added Transport#clearTimeouts Added heartbeat response handling. Added Transport#close, Transport#onClose, chanaged Transport#end.
…pty string. Added more debug instrumentation.
Added WebSocket#doClose
Fixed payloading encoding.
Changed; make sure to only emit the connection event when a client is registered for the default namespace. Added `connect` packet handler.
…This prevents Transport objects created with POST requests from triggering disconnect events too. Changed; moved forced disconnect logic into Transport#onForcedDisconnect.
- Moved all the logic into a reusable class. - Minimize globals by only exposing `client` and `create` - Separate `http.Agent` per clients so that we can terminate all sockets at once. - Implemented `create` to easily spawn a socket.io server for a given client.
Added the possibility of HTTPClient not buffering responses.
…thods added to the Store. Added support for reason passing in the store callbacks.
… POST request goes through a different connection, we want to clear the heartbeat timeout set in the connection associated with the GET request. Added disconnect reasons.
Fixed; origin verification happens at handshake time.
Merge branch 'develop' of https://github.com/LearnBoost/Socket.IO-node Conflicts: lib/manager.js lib/socket.js lib/stores/memory.js lib/transport.js lib/transports/htmlfile.js lib/transports/http-polling.js lib/transports/http.js lib/transports/jsonp-polling.js lib/transports/websocket.js
|
OH Y U kill pullrequests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flash
I added
flash policy portto the configuration object so that users who want to be able to change it, can change it. A typical use case for this would be running Node.js without root access and having IPTABLES redirect the flash policy request to the new / higher port number.Semi colons
I noticed a few missing here and there, so I added them. I also removed semicolons after function declarations.
Named functions
While I was at it, I just named all functions so our would not start bleeding if we had to take a peek at the stacktrace
Submodules
Restored the messed up submodule references, I guessed the references of
should.jsand add @visionmedia's version.. But I guess @guille's version was used instead, but that one seemed more out of date ;)