Allow sending binary data without ArrayBuffer (e. g. IE8) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingedkiwi
changed the title
| @@ -102,6 +102,11 @@ exports.encodePacket = function (packet, supportsBinary, utf8encode, callback) { | |||
| return encodeBlob(packet, supportsBinary, callback); | |||
| } | |||
|
|
|||
| // might be an object with { base64: true, data: dataAsBase64String } | |||
| if (data && data.base64) { | |||
There was a problem hiding this comment.
It'd be nice to check here for the number of keys not being any more than base64 and data
There was a problem hiding this comment.
Any suggestion to do this without introducing incompatibilities to older browsers?
There was a problem hiding this comment.
We could use something like https://github.com/ljharb/object-keys
|
+1 for next release |
|
Happy to see this will be integrated :-) Then I no longer need to manage my own forks. |
|
It'll come in |
rauchg
added a commit
that referenced
this pull request
Dec 10, 2014
Allow sending binary data without ArrayBuffer (e. g. IE8)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working with binary data in the browser and – as far as I can see – I can receive binary data which comes as an object { base64: true, data: base64Data }.
BUT there is no way to do the same to send binary data. Sending binary data strictly requires an ArrayBuffer which is not available in older browsers.
I propose to introduce the same concept for sending binary data as for receiving binary data.
Sending an object { base64: true, data: base64Data } should send the data with binary flag to the wire.
This would allow older browsers to work binary. No need to modify server code nor client code. Only the
engine.io-parser needs a small modification.
This PR would resolve #35.
It adds the proposed way to send binary data for old browsers, including test.
Personally tested on IE8. It should support all browsers that https://github.com/feross/buffer supports too.
Any chance to get this integrated? Personally it would make engine.io the best socket library available because of its comprehensive binary support.
Thanks.