Refacto aws_s3_bucket
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eliecharra
commented
Apr 29, 2021
eliecharra
commented
| Q | A |
|---|---|
| π Bug fix? | no |
| π New feature? | no |
| β Deprecations? | no |
| β BC Break | no |
| π Related issues | #347 |
| β Documentation | no |
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 69.61% 69.71% +0.09%
==========================================
Files 286 286
Lines 6641 6653 +12
==========================================
+ Hits 4623 4638 +15
+ Misses 1648 1644 -4
- Partials 370 371 +1
|
eliecharra
force-pushed
the
refacto_aws_s3_bucket
branch
from
d4d1613 to
14e2e5c
Compare
wbeuil
suggested changes
May 5, 2021
| "policy": bucket.Policy, | ||
| "id": bucket.TerraformId(), | ||
| "bucket": bucketName, | ||
| "policy": policy, |
There was a problem hiding this comment.
We could totally write it that way since we won't need bucketName or policy var anymore when S3BucketPolicy will be refactored.
data := map[string]interface{}{
"id": bucket.TerraformId(),
"bucket": (*bucket.Attrs)["bucket"],
"policy": policyAttr,
}
| "permissions": []string{"FULL_CONTROL"}, | ||
| "type": awssdk.String("CanonicalUser"), | ||
| "uri": awssdk.String(""), | ||
| }, |
There was a problem hiding this comment.
You can delete all the pointers for the attributes of each grant we won't need it anymore. Same for the other tests in this file.
eliecharra
force-pushed
the
refacto_aws_s3_bucket
branch
from
14e2e5c to
43229f9
Compare
wbeuil
previously approved these changes
May 6, 2021
eliecharra
force-pushed
the
refacto_aws_s3_bucket
branch
from
43229f9 to
98a43ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.