Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy go mod #1659

Merged
merged 1 commit into from
May 31, 2023
Merged

tidy go mod #1659

merged 1 commit into from
May 31, 2023

Conversation

chdorner-snyk
Copy link
Contributor

as instructed by go mod tidy, ran go mod tidy -go=1.16 && go mod tidy -go=1.17

did a quick sanity check on those two upgrades and fairly sure they are fine

as instructed by `go mod tidy`, ran `go mod tidy -go=1.16 && go mod tidy -go=1.17`
@chdorner-snyk chdorner-snyk requested a review from a team as a code owner May 31, 2023 13:26
@chdorner-snyk chdorner-snyk requested review from craigfurman and removed request for a team May 31, 2023 13:26
@codecov-commenter
Copy link

Codecov Report

Merging #1659 (3d824e1) into main (4a1cbbe) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1659   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files         222      222           
  Lines        7022     7022           
=======================================
  Hits         5479     5479           
  Misses       1345     1345           
  Partials      198      198           

@chdorner-snyk chdorner-snyk merged commit bf35853 into main May 31, 2023
@chdorner-snyk chdorner-snyk deleted the go-mod-tidy branch May 31, 2023 13:32
Copy link
Contributor

@craigfurman craigfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approving since this is indeed a net improvement, but ideally let's also check for no diff after go-mod-tidy in CI

@chdorner-snyk
Copy link
Contributor Author

@craigfurman #1660 :chefskiss:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants