Merge pull request #888 from snyk/chore/add-auth-headers-to-all-flows

fix: add auth headers on all flows [HYB-724]
snyk · Dec 6, 2024 · 9398c25 · 9398c25
2 parents 17d84c5 + e76e820
commit 9398c25
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/lib/client/config/configHelpers.ts b/lib/client/config/configHelpers.ts
@@ -5,6 +5,12 @@ import { getConfig, loadBrokerConfig } from '../../common/config/config';
 import version from '../../common/utils/version';
 import { CONFIGURATION } from '../../common/types/options';
 
+let globalClientOpts: Record<string, any> = {};
+
+export const getClientOpts = () => {
+  return globalClientOpts;
+};
+
 export const reloadConfig = async (clientOpts) => {
   // Reload config with connection
   await loadBrokerConfig();
@@ -14,6 +20,7 @@ export const reloadConfig = async (clientOpts) => {
     clientOpts.config,
     globalConfig.config,
   ) as Record<string, any> as CONFIGURATION;
+  globalClientOpts = clientOpts;
 };
 
 export const getClientConfigMetadata = (

diff --git a/lib/client/dispatcher/client/api.ts b/lib/client/dispatcher/client/api.ts
@@ -7,6 +7,7 @@ import {
   DispatcherServiceClient,
   ServerId,
 } from '../dispatcher-service';
+import { getClientOpts } from '../../config/configHelpers';
 
 export class HttpDispatcherServiceClient implements DispatcherServiceClient {
   private readonly version = '2022-12-01~experimental';
@@ -24,12 +25,14 @@ export class HttpDispatcherServiceClient implements DispatcherServiceClient {
       const path = `/hidden/broker/${params.hashedBrokerToken}/connections/${params.brokerClientId}`;
       const url = new URL(path, this.baseUrl);
       url.searchParams.append('version', this.version);
+      const headers = { 'Content-type': 'application/vnd.api+json' };
+      if (getClientOpts().accessToken) {
+        headers['Authorization'] = getClientOpts().accessToken?.authHeader;
+      }
       const req: PostFilterPreparedRequest = {
         url: url.toString(),
         method: 'POST',
-        headers: {
-          'Content-type': 'application/vnd.api+json',
-        },
+        headers,
         body: JSON.stringify({
           data: {
             attributes: {

diff --git a/lib/client/socket.ts b/lib/client/socket.ts
@@ -138,6 +138,8 @@ export const createWebSocket = (
     socketSettings['transport'] = {
       extraHeaders: {
         Authorization: clientOpts.accessToken?.authHeader,
+        'x-snyk-broker-client-id': identifyingMetadata.clientId,
+        'x-snyk-broker-client-role': identifyingMetadata.role,
       },
     };
   }
@@ -171,8 +173,8 @@ export const createWebSocket = (
         clientOpts.config.brokerClientConfiguration.common.oauth!.clientSecret,
       );
 
-      // websocket.transport.extraHeaders['Authorization'] =
-      //   clientOpts.accessToken!.authHeader;
+      websocket.transport.extraHeaders['Authorization'] =
+        clientOpts.accessToken!.authHeader;
       // websocket.end();
       // websocket.open();
       timeoutHandlerId = setTimeout(

diff --git a/lib/hybrid-sdk/http/downstream-post-stream-to-server.ts b/lib/hybrid-sdk/http/downstream-post-stream-to-server.ts
@@ -9,6 +9,7 @@ import { bootstrap } from 'global-agent';
 import https from 'https';
 import http from 'http';
 import { getConfig } from '../../common/config/config';
+import { getClientOpts } from '../../client/config/configHelpers';
 
 const BROKER_CONTENT_TYPE = 'application/vnd.broker.stream+octet-stream';
 
@@ -68,6 +69,7 @@ class BrokerServerPostResponseHandler {
           this.#streamingId
         }`,
       );
+
       if (this.#serverId) {
         url.searchParams.append('server_id', this.#serverId);
       }
@@ -94,6 +96,10 @@ class BrokerServerPostResponseHandler {
           ? parseInt(this.#config.brokerClientPostTimeout)
           : 1200000,
       };
+      if (getClientOpts().accessToken) {
+        options.headers['authorization'] =
+          getClientOpts().accessToken.authHeader;
+      }
 
       this.#brokerSrvPostRequestHandler = client.request(
         brokerServerPostRequestUrl,