Run unit tests in parallel #1772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fcampbell
force-pushed
the
frank-parallel-unit-tests
branch
from
a84e8a5 to
f383a37
Compare
sfc-gh-melnacouzi
approved these changes
Oct 23, 2024
sfc-gh-mchok
approved these changes
Oct 23, 2024
| # "pip install test_external_plugins/snowpark_hello_single_command", | ||
| # "pip install test_external_plugins/multilingual_hello_command_group", | ||
| "pip install pytest-xdist", | ||
| ] |
There was a problem hiding this comment.
Is this still expected change?
There was a problem hiding this comment.
Yeah, it's in the dev requirements now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Unit test time is creeping up, let's take advantage of our CI runners and make them run in parallel. I checked back a few months and the time was at about 10 mins, now they're approaching 12-13 mins, almost as long as the integration tests. Since integration tests are longer, this doesn't speed up overall CI, but it does allow us to get fast feedback when tests fail.
I verified that the coverage report is identical between serial and parallel execution.
Something is up with GH actions compared to a laptop, where the whole suite can run in about 30 seconds, but investigating that is sort of out of scope for now.