Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multimedia support in KDE is broken #228

Open
5HT2 opened this issue Oct 21, 2019 · 11 comments
Open

Multimedia support in KDE is broken #228

5HT2 opened this issue Oct 21, 2019 · 11 comments
Labels

Comments

@5HT2
Copy link

5HT2 commented Oct 21, 2019

🐛 Bug report

What issue are you facing

Multimedia support is broken, as such media keys are also broken. I cannot pause / skip in the multimedia center on KDE
Screenshot_20191021_112226

Steps to reproduce

  1. Play a song
  2. Open multimedia center

Environment

Operating System: KDE neon 5.17
KDE Plasma Version: 5.17.0
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Kernel Version: 5.0.0-31-generic
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5-6300HQ CPU @ 2.30GHz
Memory: 7.6 GiB of RAM

Which version of Auryo?

2.4.0

@5HT2
Copy link
Author

5HT2 commented Oct 21, 2019

Example multimedia:
Screenshot_20191021_113350

Album artwork doesn't show because the soundcloud website doesn't support it but at least time and skipping works

@sneljo1
Copy link
Owner

sneljo1 commented Feb 19, 2020

Will mark this as fixed, please notify me if the issue persist with the version I am about to release.

@BlobCodes
Copy link

Screenshot_20200223_000344

It correctly shows the thumbnail now (although in a very bad quality)
As you can see, the times are not correctly shown.

@sneljo1
Copy link
Owner

sneljo1 commented Feb 23, 2020

Allright, I can fix the thumbnail for sure. For the position, I will have to check. I have a hard time testing MPRIS. I've been using Ubuntu as my testing distro, but I am unable to get the MPRIS widget to show up for some reason.

@5HT2
Copy link
Author

5HT2 commented Feb 23, 2020

Try KDE Neon, it's multimedia support is years better

@BlobCodes
Copy link

@Superjo149 Just saw the new commit eaa544f and tried it.
Screenshot_20200224_205635
Although media playback didn't work when testing (and the time given to the widget differs from the real time), everything now looks pretty nice.

@sneljo1
Copy link
Owner

sneljo1 commented Feb 25, 2020

Neat, will wait to release until I get some more features or bugs in.

@sneljo1
Copy link
Owner

sneljo1 commented Mar 4, 2020

Not sure what is up with the length & position. I'll need to check out the spec again. I think I'm passing milliseconds, but it might need something else. But the other fixes are in in the new v2.5.3

@BlobCodes
Copy link

@Superjo149 I just tried some things and have some hints how to solve this.

I actually got auryo to show the correct times, by changing the following line:

return Math.round(time * 1e3);

..into..

return Math.round(time * 1e6);

(You gave milliseconds, but it wanted microseconds)

Here's a screenshot:

Screenshot_20200306_204559
(Please notice the time being 1-2 seconds off , I think that's because auryo uses rounding)

One major flaw however is that when pausing/resuming a track, the played time gets reset in the widget only.

Screenshot_20200306_204812
(Paused and resumed after half of the track)

Looks like correct mpris support is near 😄

@BlobCodes
Copy link

Just found out that the pause/resume time reset bug only occurs when I enabled automatic detection of media players.

Meaning the following must have happened:

  • When pausing, KDE looks for other audio sources (which it finds)
  • Because of that, KDE forgets how much was already played
  • Auryo does not re-send the current location

@BlobCodes
Copy link

MPRIS Docs -> https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html

Here you can see it actually wants microseconds.

KebabLord pushed a commit to KebabLord/logtrack_feature that referenced this issue Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants