feat: add Advanced settings for offchain spaces.

[Sekhmet]

Summary

Adding advanced settings page for offchain spaces with following options:

• Sub-spaces (parent and child spaces)
• Terms of services
• Custom domain
• Hide from homepage
• Delete space

Had to make some adjustments from the design, as not everything was clear:

• Not extraneous modals for parent-space, sub-space, custom-domain (in designs we have input, but also modal that opens for you to type in, which I'm not sure makes sense, here I just use inputs directly avoiding modals.
• Designs didn't cover how already added sub-spaces should look like, so I improvised.
• No tooltip for custom domain input as we don't have it either on v1 so I didn't have text to use.

Closes: #

How to test

1. Create new space (if you want to delete it, you will lose ability to recreate space under that domain).
2. Go to your space, enter settings, you can modify advanced settings.
3. You can delete your space.

Screenshots

[changeset-bot]

🦋 Changeset detected

Latest commit: f3c0791

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@snapshot-labs/sx	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Sekhmet]

@bonustrack will need text for this section.

[bonustrack]

It should be possible to add both a main space, and a sub spaces, it's not one or the other.

Also ideally we shouldn't allow duplicate for sub spaces.

[wa0x6e]

Disabled danger button should have disabled border color

[wa0x6e]

The parent and child space input form should have a loading indicator

[wa0x6e]

Dirtying any fields in the new ADVANCED tab is not showing the bottom toolbar with SAVE button

[wa0x6e]

Should prevent duplicate in child spaces

[wa0x6e]

It should be possible to add both a main space, and a sub spaces, it's not one or the other.

Also ideally we shouldn't allow duplicate for sub spaces.

Seems like on v1, it's one or the other, both are not possible

[wa0x6e]

Space between checkbox and label seen insufficient

[Sekhmet]

The parent and child space input form should have a loading indicator

Updated it to have similar space validation UX as v1.

Dirtying any fields in the new ADVANCED tab is not showing the bottom toolbar with SAVE button

Should be fixed now.

Space between checkbox and label seen insufficient

Followed designs there, but I agree this doesn't look good, increased it to gap-2.

[Sekhmet]

It should be possible to add both a main space, and a sub spaces, it's not one or the other.

As Wan mentioned this replicates v1 UI that prevents configuring both parent and sub-spaces at the same time. I can remove that validation if we confirm that's what we want.

[wa0x6e]

The domain name field is missing the length validation

Putting something over the char limit does not show any errors.

And it's not on v1, but maybe it's time to also put a proper domain name validation on this field, since we'll be using it automatically for the whitelabel

On v1, there's a human manual validation, but we're moving away from that for v2

[wa0x6e]

When putting an invalid space name in the parent space, it shows an error.

But it we change tab, and go back to advanced, the error state is gone.

There seems to be a query to check if the space is valid (loading icon on the input on tab change), but the error state is not being restored

[wa0x6e]

Shouldn't the message be different ?

[Sekhmet]

When putting an invalid space name in the parent space, it shows an error.
But it we change tab, and go back to advanced, the error state is gone.
There seems to be a query to check if the space is valid (loading icon on the input on tab change), but the error state is not being restored

It's broken app-wide, we should fix it properly, but not really belongs in this PR, we can workaround it by using v-show which is not ideal (used it there for now).
#573

[Sekhmet]

And it's not on v1, but maybe it's time to also put a proper domain name validation on this field, since we'll be using it automatically for the whitelabel

What you consider proper domain name validation? I think anything "proper" would be out of scope of this PR.

[wa0x6e]

When reaching the max number of sub-spaces, the sub-space form is still accepting value, and validating space name.

But does not show any error when the space name is valid. I think it should show the error about reaching the max number of sub-spaces

[wa0x6e]

out of scope of this PR.

For now, just alphanum, ., _ and - will cover 100% of our existing list (https://github.com/snapshot-labs/snapshot-spaces/blob/master/spaces/domains.json) we can optimize later

[wa0x6e]

With some unsaved valid changes, navigating between non-advanced tab is keeping the bottom toolbar (with the save button) always shown.

But when navigating to advanced tab, the toolbar disappear for a spit-second, before reappearing

nevermind, can not reproduce anymore with the latest updates

[bonustrack]

tACK

[wa0x6e]

Looks like the dirty state of the sub-spaces is only looking at the number of spaces.

Example:

• My space already 3 sub-spaces
• I remove 1 space -> SAVE button shows up
• I add another different space -> SAVE button disappear

[wa0x6e]

tAck