-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always show voting type selection in Editor #512
Conversation
On the space "fabien.eth" I've enforced voting type to be "basic" from the space settings but I still can select a different voting type in the UI. (Actually this issue is not specific to this PR). |
Going back to draft, to include fix for #516 |
Also added in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small comments, most of which should be resolved by rebase.
After that it's good to go for me.
@@ -34,11 +44,17 @@ function handleVoteTypeSelected(type: VoteType) { | |||
<h4 class="eyebrow mb-2.5">Voting type</h4> | |||
<button | |||
type="button" | |||
class="border rounded-xl py-2.5 px-3 flex gap-3 text-left relative border-skin-content w-full" | |||
@click="modalOpen = true" | |||
class="border rounded-xl py-2.5 px-3 flex text-left relative border-skin-content w-full" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's disable this button this way it's not focusable and more accessible. Then we don't need to check hasMultipleVotingType
on handler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Summary
Closes: #509 #516
Summary:
This PR will resolves #509 by:
This PR wil resolves #516 by:
voting_types
(VoteType[]
) property toSpace
, which will hold the whitelist of voting type for the given space. Offchain will get the list from the graphql results, whereas onchains's one will be set from a constantHow to test
Basic Choice
.Single Choice
being the default selectionSingle Choice
, as it's the type set by the space