Move memchr behind an optional feature #77
Conversation
|
You have to add memchr feature to the value of --skip. futures-lite/.github/workflows/ci.yml Line 45 in 32cc466 |
Closes #76 Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
notgull
force-pushed
the
notgull/memchr
branch
from
2cef7a8 to
37d2684
Compare
Cargo.toml
Outdated
| alloc = [] | ||
| memchr = ["std", "memchr_crate"] |
There was a problem hiding this comment.
Considering the future support of core::io, I wonder if the memchr feature should not enable the std feature. However, I'm not sure if that will happen during the period when 2.x is the latest version.
There was a problem hiding this comment.
As of now futures-lite uses futures-io v0.3. I expect that v0.3 probably won't export core::io traits without a breaking change, right? So I think we are secure in doing this for now.
There was a problem hiding this comment.
futures-io has (enabled by default) std feature for future compatibility about this.
There was a problem hiding this comment.
Good point, I've decouple std and memchr.
|
LGTM |
Signed-off-by: John Nunley <[email protected]>
Since #77, this crate works on 1.60.
Since #77, this crate works on 1.60.
Closes #76