Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Unpin from lines #113

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: remove Unpin from lines #113

merged 1 commit into from
Nov 4, 2024

Conversation

nanoqsh
Copy link
Contributor

@nanoqsh nanoqsh commented Nov 4, 2024

Is Unpin really needed here?
The lines method takes self as a value and pins inside Lines struct, so there is no need to require Unpin

taiki-e
taiki-e approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e merged commit bf22c0e into smol-rs:master Nov 4, 2024
7 checks passed
@notgull notgull mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanoqsh @taiki-e