Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop completed futures in Zip and TryZip #106

Merged
merged 2 commits into from
Aug 25, 2024
Merged

fix: drop completed futures in Zip and TryZip #106

merged 2 commits into from
Aug 25, 2024

Conversation

nanoqsh
Copy link
Contributor

@nanoqsh nanoqsh commented Aug 22, 2024

Fixes #105

notgull
notgull approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, rebase on master to please Clippy.

@notgull @nanoqsh
m: Silence clippy
e31b226 
usize::max_value() => usize::MAX

Signed-off-by: John Nunley <[email protected]>
@nanoqsh
Copy link
Contributor Author

nanoqsh commented Aug 23, 2024

@notgull it's done

notgull
notgull approved these changes Aug 25, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@notgull notgull merged commit 12509a0 into smol-rs:master Aug 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should future::zip drop completed futures?
2 participants
@nanoqsh @notgull