feat: add StreamExt::take_until.
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 27, 2024 09:57
This commit migrates `Stream::take_until` from futures into futures-lite, with little modification. version are updated, as well.
This commit migrates `Stream::take_until` from futures into futures-lite with little modification. version are also updated.
# Conflicts: # src/stream.rs
notgull
requested changes
May 27, 2024
src/stream.rs
Outdated
| /// | ||
| /// assert_eq!(vec![1, 2, 3, 4, 5], stream.collect::<Vec<_>>().await); | ||
| /// # }); | ||
| fn take_until<F>(self, future: F) -> TakeUntil<Self, F> |
There was a problem hiding this comment.
I would prefer this as a free function, rather than a member of the trait.
There was a problem hiding this comment.
I will move it out of this trait, but I'd remind you that futures library take it as a member of StreamExt
…StreamExt` trait.
notgull
requested changes
May 28, 2024
Co-authored-by: John Nunley <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates
Stream::take_untilfrom futures into futures-lite with little modification.version are also updated.