Finish backporting changes to JSON-RPC API #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #960
This finishes backporting paritytech/json-rpc-interface-spec#66
Overall it was pretty straight forward, however this is completely untested.
In terms of code, I'm moderately happy about it. There's a lot of boilerplate because we're no longer using the "infrastructure" that
ClientMainTaskis providing.I'm not completely sure what to do here. Assuming that the full node will implement the API as well, it would make sense to integrate these new features into the
ClientMainTask. However this is complicated and I don't really know how I'd do that.