Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authoringVersion field from runtime spec #815

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Remove authoringVersion field from runtime spec #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96c9e4d
Remove `authoringVersion` field from runtime spec
tomaka Jun 25, 2023
605d36b
PR link
tomaka Jun 25, 2023
9645145
Merge branch 'main' into rm-authoring-version
tomaka Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/src/json_rpc/methods.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,15 +1038,12 @@ pub struct RuntimeSpec<'a> {
pub spec_name: Cow<'a, str>,
#[serde(rename = "implName")]
pub impl_name: Cow<'a, str>,
#[serde(rename = "authoringVersion")]
pub authoring_version: u32,
#[serde(rename = "specVersion")]
pub spec_version: u32,
#[serde(rename = "implVersion")]
pub impl_version: u32,
#[serde(rename = "transactionVersion", skip_serializing_if = "Option::is_none")]
pub transaction_version: Option<u32>,
// TODO: add `state_version`? would need a JSON-RPC API interface spec change
pub apis: HashMap<HexString, u32, fnv::FnvBuildHasher>,
}

Expand Down
1 change: 0 additions & 1 deletion light-base/src/json_rpc_service/background/chain_head.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,6 @@ fn convert_runtime_spec(
spec_name: runtime.spec_name.into(),
impl_version: runtime.impl_version,
spec_version: runtime.spec_version,
authoring_version: runtime.authoring_version,
transaction_version: runtime.transaction_version,
apis: runtime
.apis
Expand Down
1 change: 1 addition & 0 deletions wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Changed

- The runtime specification yielded by the `chainHead_unstable_follow` JSON-RPC function no longer includes the `authoringVersion` field, in accordance with the latest changes in the JSON-RPC API specification. ([#815](https://github.com/smol-dot/smoldot/pull/815))
- The `chainHead_unstable_unpin` JSON-RPC function now accepts either a single hash or an array of hashes, in accordance with the latest changes in the JSON-RPC API specification. ([#814](https://github.com/smol-dot/smoldot/pull/814))
- Add support for the `descendants-values`, `descendants-hashes`, and `closest-ancestor-merkle-value` types for the `chainHead_unstable_storage` JSON-RPC function. ([#813](https://github.com/smol-dot/smoldot/pull/813))
- The `chainHead_unstable_storage` JSON-RPC function now accepts an array of `items` as parameter instead of a `key` and `type`, in accordance with the latest changes in the JSON-RPC API specification. ([#813](https://github.com/smol-dot/smoldot/pull/813))
Expand Down