Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #807 #808

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix #807 #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4669cf0
Fix #807
tomaka Jun 23, 2023
510154f
PR link
tomaka Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/src/sync/all.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,6 +1816,9 @@ impl<TRq, TSrc, TBl> AllSync<TRq, TSrc, TBl> {
.position(|(_, id, ..)| *id == request_id)
.unwrap();
let (_, _, user_data, _) = sync.in_progress_requests.remove(pos);
self.inner = AllSyncInner::GrandpaWarpSync {
inner: warp_sync::WarpSync::Finished(sync),
};
(user_data.user_data, ResponseOutcome::Outdated)
}
// Only the GrandPa warp syncing ever starts GrandPa warp sync requests.
Expand Down Expand Up @@ -1893,6 +1896,9 @@ impl<TRq, TSrc, TBl> AllSync<TRq, TSrc, TBl> {
.position(|(_, id, ..)| *id == request_id)
.unwrap();
let (_, _, user_data, _) = sync.in_progress_requests.remove(pos);
self.inner = AllSyncInner::GrandpaWarpSync {
inner: warp_sync::WarpSync::Finished(sync),
};
(user_data.user_data, ResponseOutcome::Outdated)
}
// Only the GrandPa warp syncing ever starts call proof requests.
Expand Down
1 change: 1 addition & 0 deletions wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Fix not absorbing the JavaScript exception triggered by the browser when connecting to a `ws://` node when smoldot is embedded in a web page served over `https://`. ([#795](https://github.com/smol-dot/smoldot/pull/795), [#800](https://github.com/smol-dot/smoldot/pull/800))
- Smoldot no longer calls `close()` on WebSockets that aren't fully established yet (even though it is legal to do so according to the WHATWG specification) in order to avoid browsers printing warnings in the console when you do so. ([#799](https://github.com/smol-dot/smoldot/pull/799))
- Fix panic-inducing race condition when a networking event happens right when the warp syncing finishes. ([#808](https://github.com/smol-dot/smoldot/pull/808))

## 1.0.10 - 2023-06-19

Expand Down