Make child tries work properly #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #166
This PR updates the child tries implementation after w3f/polkadot-spec#648 (comment)
It moves all the child-trie-related handling that was in
host.rstoruntime_host.rswhere it is more appropriate. I initially thought thathost.rscould provide a reasonable abstraction, but it actually makes more sense to do everything inruntime_host.rsand lethost.rsgenerate events that map precisely to the functions that the runtime calls.It also makes sure to recalculate the root hash of every child trie before calculating the main trie hash. This is in line with what is explained in w3f/polkadot-spec#577
The test in #722 works on top of this PR.
I'm going to do a documentation pass on this PR before merging it, as there might be several comments that are no longer accurate.