Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when decoding BABE config when API version is 1 #739

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix bug when decoding BABE config when API version is 1 #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6554862
Fix bug when decoding BABE config when API version is 1
tomaka Jun 14, 2023
c7f6dd3
PR link
tomaka Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 90 additions & 1 deletion lib/src/chain/chain_information/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,7 @@ fn decode_aura_authorities_output(
}
}

#[derive(Debug, Clone, PartialEq, Eq)]
struct BabeGenesisConfiguration {
slots_per_epoch: NonZeroU64,
epoch0_configuration: header::BabeNextConfig,
Expand Down Expand Up @@ -889,7 +890,7 @@ fn decode_babe_configuration_output(
header::BabeAllowedSlots::PrimarySlots
}),
nom::combinator::map(nom::bytes::complete::tag(&[1]), |_| {
header::BabeAllowedSlots::PrimaryAndSecondaryVrfSlots
header::BabeAllowedSlots::PrimaryAndSecondaryPlainSlots
}),
))(b)
} else {
Expand Down Expand Up @@ -1055,6 +1056,9 @@ fn decode_grandpa_current_set_id_output(bytes: &[u8]) -> Result<u64, Error> {

#[cfg(test)]
mod tests {
use crate::header;
use core::num::NonZeroU64;

#[test]
fn decode_babe_epoch_output_sample_decode() {
// Sample taken from an actual Westend block.
Expand All @@ -1075,4 +1079,89 @@ mod tests {

super::decode_babe_epoch_output(&sample_data, true).unwrap();
}

#[test]
fn decode_babe_configuration_output_v1() {
let data = [
112, 23, 0, 0, 0, 0, 0, 0, 88, 2, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 4, 0, 0, 0,
0, 0, 0, 0, 24, 202, 35, 147, 146, 150, 4, 115, 254, 27, 198, 95, 148, 238, 39, 216,
144, 164, 156, 27, 32, 12, 0, 111, 245, 220, 197, 37, 51, 14, 204, 22, 119, 1, 0, 0, 0,
0, 0, 0, 0, 180, 111, 1, 135, 76, 231, 171, 187, 82, 32, 232, 253, 137, 190, 222, 10,
218, 209, 76, 115, 3, 157, 145, 226, 142, 136, 24, 35, 67, 62, 114, 63, 1, 0, 0, 0, 0,
0, 0, 0, 214, 132, 217, 23, 109, 110, 182, 152, 135, 84, 12, 154, 137, 250, 96, 151,
173, 234, 130, 252, 75, 15, 242, 109, 16, 98, 180, 136, 243, 82, 225, 121, 1, 0, 0, 0,
0, 0, 0, 0, 104, 25, 90, 113, 189, 222, 73, 17, 122, 97, 100, 36, 189, 198, 10, 23, 51,
233, 106, 203, 29, 165, 174, 171, 93, 38, 140, 242, 165, 114, 233, 65, 1, 0, 0, 0, 0,
0, 0, 0, 26, 5, 117, 239, 74, 226, 75, 223, 211, 31, 76, 181, 189, 97, 35, 154, 230,
124, 18, 212, 230, 74, 229, 26, 199, 86, 4, 74, 166, 173, 130, 0, 1, 0, 0, 0, 0, 0, 0,
0, 24, 22, 143, 42, 173, 0, 129, 162, 87, 40, 150, 30, 224, 6, 39, 207, 227, 94, 57,
131, 60, 128, 80, 22, 99, 43, 247, 193, 77, 165, 128, 9, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 1,
];

assert_eq!(
super::decode_babe_configuration_output(&data, true).unwrap(),
super::BabeGenesisConfiguration {
slots_per_epoch: NonZeroU64::new(600).unwrap(),
epoch0_configuration: header::BabeNextConfig {
allowed_slots: header::BabeAllowedSlots::PrimaryAndSecondaryPlainSlots,
c: (1, 4),
},
epoch0_information: header::BabeNextEpoch {
authorities: vec![
header::BabeAuthority {
public_key: [
202, 35, 147, 146, 150, 4, 115, 254, 27, 198, 95, 148, 238, 39,
216, 144, 164, 156, 27, 32, 12, 0, 111, 245, 220, 197, 37, 51, 14,
204, 22, 119
],
weight: 1
},
header::BabeAuthority {
public_key: [
180, 111, 1, 135, 76, 231, 171, 187, 82, 32, 232, 253, 137, 190,
222, 10, 218, 209, 76, 115, 3, 157, 145, 226, 142, 136, 24, 35, 67,
62, 114, 63
],
weight: 1
},
header::BabeAuthority {
public_key: [
214, 132, 217, 23, 109, 110, 182, 152, 135, 84, 12, 154, 137, 250,
96, 151, 173, 234, 130, 252, 75, 15, 242, 109, 16, 98, 180, 136,
243, 82, 225, 121
],
weight: 1
},
header::BabeAuthority {
public_key: [
104, 25, 90, 113, 189, 222, 73, 17, 122, 97, 100, 36, 189, 198, 10,
23, 51, 233, 106, 203, 29, 165, 174, 171, 93, 38, 140, 242, 165,
114, 233, 65
],
weight: 1
},
header::BabeAuthority {
public_key: [
26, 5, 117, 239, 74, 226, 75, 223, 211, 31, 76, 181, 189, 97, 35,
154, 230, 124, 18, 212, 230, 74, 229, 26, 199, 86, 4, 74, 166, 173,
130, 0
],
weight: 1
},
header::BabeAuthority {
public_key: [
24, 22, 143, 42, 173, 0, 129, 162, 87, 40, 150, 30, 224, 6, 39,
207, 227, 94, 57, 131, 60, 128, 80, 22, 99, 43, 247, 193, 77, 165,
128, 9
],
weight: 1
}
],
randomness: [0; 32]
},
}
);
}
}
1 change: 1 addition & 0 deletions wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Fixed

- Fix wrong trie root hash calculation with `state_version = 1`. ([#711](https://github.com/smol-dot/smoldot/pull/711))
- Fix bug when decoding BABE configuration produced by runtimes using version 1 of the `BabeApi` API. In practice, this should concern only old Kusama blocks. ([#739](https://github.com/smol-dot/smoldot/pull/739))

## 1.0.9 - 2023-06-08

Expand Down