Modify runtime_host.rs to support child tries
#684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #166
This PR finishes adding support for child tries in the light client.
A list of child trie diffs is now maintained in
runtime_host.rs(the equivalent of the so-called overlay in Substrate).In terms of API, all the query variants now have a
child_trie()function that should be inspected before fulfilling the request.The
ClosestDescendantMerkleValuehad to be modified to accept anOptionfor the Merkle value, as it is now possible for the child trie to not exist.There are several uncertainties w.r.t. how child tries work, and they'll need to be fixed with further PRs. However, this is unlikely to require any more API change.