Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #166
At the moment, when decoding a proof, it is assumed that this proof only contains one trie, and the user is required to pass the expected trie root hash.
However, in the context of child tries, a proof can contain entries from multiple different tries (the main trie and child tries).
Normally, these tries are connected in the sense that the value of a main trie node starting with
:child_storage:default:
is equal to the root of another trie. However, I prefer to not put this assumption in the proof-related code.Instead, I've adjusted the code to allow multiple different tries within the same proof, without checking whether these tries are connected to each other.
In terms of API changes, the API user no longer passes the expected trie root hash when decoding the proof, but instead passes the trie root hash whenever the proof is accessed. If the proof doesn't contain the requested trie, then
None
is returned, indicating an incomplete proof.