Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chainHead_unstable_stopStorage and chainHead_unstable_stopBody being mixed #648

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix chainHead_unstable_stopStorage and chainHead_unstable_stopBody being mixed #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e4f5b1
Fix `chainHead_unstable_stopStorage` and `chainHead_unstable_stopBody…
tomaka May 31, 2023
133ea95
PR link
tomaka May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions light-base/src/json_rpc_service/background/chain_head.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ impl<TPlat: PlatformRef> ChainHeadFollowTask<TPlat> {
break;
}
either::Right((
SubscriptionMessage::StopIfChainHeadStorage { stop_request_id },
SubscriptionMessage::StopIfChainHeadBody { stop_request_id },
confirmation_sender,
)) => {
requests_subscriptions
Expand Down Expand Up @@ -1505,7 +1505,7 @@ impl<TPlat: PlatformRef> ChainHeadFollowTask<TPlat> {
break;
}
either::Right((
SubscriptionMessage::StopIfChainHeadBody { stop_request_id },
SubscriptionMessage::StopIfChainHeadStorage { stop_request_id },
confirmation_sender,
)) => {
requests_subscriptions
Expand Down
1 change: 1 addition & 0 deletions wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Fixed

- Fix panic when receiving a networking request of a protocol not supported by smoldot. ([#635](https://github.com/smol-dot/smoldot/pull/635))
- Fix `chainHead_unstable_stopStorage` and `chainHead_unstable_stopBody` being mixed. In other words, storage requests were interrupted by `chainHead_unstable_stopBody` and body requests were interrupted by `chainHead_unstable_stopStorage` ([#648](https://github.com/smol-dot/smoldot/pull/648))

## 1.0.7 - 2023-05-25

Expand Down