Expose the warp_sync::BuildRuntime and warp_sync::BuildChainInformation variants from all.rs
#644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relatively big refactor makes the API user of
all.rsmanually indicate to build the runtime or the chain information during the warp syncing.In addition to exposing a better API, this also no longer silently discards the errors that happen during this process.
The big refactor is necessary because the
WarpSync(InProgress)enum variant is nowWarpSync(InProgress | Finished). All the code that expects theWarpSyncto be in progress now need to also handle the situation where it is already finished and just waiting to be transitioned to a different syncing strategy.