Change the way buffers are passed to the wasm-node #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #375
This PR modifies the way the JS passes buffers to the Rust.
Instead of calling an
alloc
function to allocate memory in the Wasm, the JS now locally assigns a "buffer index", and the Rust uses host functions in order to obtain the properties of each "buffer index".This makes things more simple, and also fixes a potential undefined behavior.
One small wart is that the
connection_new
function (JS function called by the Rust) requires allocating a buffer index that can only be freed "some time in the future" rather than at a determinate point in time.However, this is in practice not a problem given that buffer index 0 is constantly written over.