Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename StorageDiff to TrieDiff #329

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Mar 21, 2023

Step towards #166

We want to keep the existing StorageDiff, but it will only represent the diff between a trie and another rather than between the entire chain state and another.

@github-actions
Copy link

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────
        +522 ┊ <core::iter::sources::from_fn::FromFn<F> as core::iter::traits::iterator::Iterator>::next::hab836dc90d5be786
        -522 ┊ <core::iter::sources::from_fn::FromFn<F> as core::iter::traits::iterator::Iterator>::next::hdb06b6035d40938d
        +457 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold::h1bd90fea52dc6f09
        -457 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold::h32d35dc60cfcc209
        -298 ┊ <core::iter::adapters::filter::Filter<I,P> as core::iter::traits::iterator::Iterator>::next::h320a2e99aed40dd4
        +298 ┊ <core::iter::adapters::filter::Filter<I,P> as core::iter::traits::iterator::Iterator>::next::h3e5c2bc703662621
        -268 ┊ smoldot::executor::storage_diff::StorageDiff<T>::storage_prefix_keys_ordered::h90095168fa97823c
        +268 ┊ smoldot::executor::storage_diff::TrieDiff<T>::storage_prefix_keys_ordered::hfeecb7d92e859346
        -267 ┊ smoldot::executor::storage_diff::StorageDiff<T>::diff_insert::hbab243fed07cb375
        +267 ┊ smoldot::executor::storage_diff::TrieDiff<T>::diff_insert::h3a0029d039205360
        -250 ┊ smoldot::executor::storage_diff::StorageDiff<T>::diff_insert_erase::h784e8f1177c5d2b6
        +250 ┊ smoldot::executor::storage_diff::TrieDiff<T>::diff_insert_erase::h8f3786d6e7c3b6f3
        -244 ┊ smoldot::executor::storage_diff::StorageDiff<T>::diff_insert::hea7173a5effb78f3
        +244 ┊ smoldot::executor::storage_diff::TrieDiff<T>::diff_insert::h3ab0659117821db4
        -237 ┊ smoldot::executor::storage_diff::StorageDiff<T>::diff_insert_erase::hb80f2c0208bab9d9
        +237 ┊ smoldot::executor::storage_diff::TrieDiff<T>::diff_insert_erase::h5d7fb7972bb5ba26
        -114 ┊ <hashbrown::map::HashMap<K,V,S,A> as core::iter::traits::collect::Extend<(K,V)>>::extend::hd77ec4fab426779e
        +114 ┊ <hashbrown::map::HashMap<K,V,S,A> as core::iter::traits::collect::Extend<(K,V)>>::extend::hf6789824ef3c8e70
        -109 ┊ <hashbrown::set::HashSet<T,S,A> as core::iter::traits::collect::FromIterator<T>>::from_iter::h8743c8a529efec4a
        +109 ┊ <hashbrown::set::HashSet<T,S,A> as core::iter::traits::collect::FromIterator<T>>::from_iter::hea7b181bcfe56cbd
          +0 ┊ ... and 26 more.
         -43 ┊ Σ [46 Total Rows]

@tomaka tomaka added this pull request to the merge queue Mar 21, 2023
@tomaka tomaka merged commit 457d9eb into smol-dot:main Mar 21, 2023
@tomaka tomaka deleted the storage-diff-to-trie-diff branch March 21, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant