Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove host::Error::WrongParamTy as it can't happen anymore #245

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 28, 2023

Given that host function signatures are now checked at initialization (#183), it can't happen anymore that the runtime passes a parameter of the wrong type. This is ensured by the Wasm VM.

@tomaka tomaka enabled auto-merge February 28, 2023 16:39
@tomaka tomaka added this pull request to the merge queue Feb 28, 2023
@github-actions
Copy link

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────
       -9571 ┊ smoldot::executor::host::ReadyToRun::run_once::h80cf4f232b7dc076
       -1731 ┊ <&T as core::fmt::Display>::fmt::h26682a0d1742d67b
       +1515 ┊ <&T as core::fmt::Display>::fmt::h29330ad1a6dfc0c6
       -1064 ┊ <smoldot::executor::host::Error as core::fmt::Debug>::fmt::hf55ef125bf04ab80
        +927 ┊ <smoldot::executor::host::Error as core::fmt::Debug>::fmt::h60f90c510f26338d
        -413 ┊ <smoldot::executor::host::Error as core::clone::Clone>::clone::hc1965d2975e47f93
        +367 ┊ <smoldot::executor::host::Error as core::clone::Clone>::clone::hdd6dbdf054411509
        -208 ┊ smoldot::executor::host::Inner::alloc::h24deaf212dd15f17
        +208 ┊ smoldot::executor::host::Inner::alloc::hf46ab8be55f70e11
        -112 ┊ data[0]
         +63 ┊ core::ptr::drop_in_place<smoldot::executor::host::Error>::h1db292565c81cf60
         -63 ┊ core::ptr::drop_in_place<smoldot::executor::host::Error>::h71e655456c626e8d
         -63 ┊ core::ptr::drop_in_place<smoldot::executor::host::Error>::h98ec53de5d641ebb
         +63 ┊ core::ptr::drop_in_place<smoldot::executor::host::Error>::he24f0d4dc729fb03
         -52 ┊ <smoldot_light::runtime_service::RuntimeCallError as core::clone::Clone>::clone::h1a7c7e2c1b4fa4aa
         +17 ┊ <&T as core::fmt::Debug>::fmt::ha8524c19856de8b8
         -17 ┊ <&T as core::fmt::Debug>::fmt::hbb1732b2f1b58949
          +6 ┊ <&T as core::fmt::Display>::fmt::hd613e9b79c40ba29
      -10128 ┊ Σ [18 Total Rows]

Merged via the queue into smol-dot:main with commit d5f9527 Feb 28, 2023
@tomaka tomaka deleted the rm-wrong-param-err branch February 28, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant