Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate the Store from scratch on wasmi every time #211

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 22, 2023

cc #17

@tomaka tomaka enabled auto-merge February 22, 2023 10:50
@github-actions
Copy link

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────
      -12219 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::new::he05ceb949ecca769
      +11707 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::new::h469e299f97142227
       +2005 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::from_base_components::hb5b40b3cd0256410
        -992 ┊ smoldot::executor::vm::interpreter::InterpreterPrototype::from_components::h678454c3bcdf00f8
        -351 ┊ wasmi::func::HostFuncEntity<T>::new::hb75c197bf8cc5ad1
        +351 ┊ wasmi::func::HostFuncEntity<T>::new::he41fcb93a1829ee3
        -330 ┊ wasmi::func::HostFuncEntity<T>::new::{{closure}}::h4d6cc7a79dbd4c93
        +330 ┊ wasmi::func::HostFuncEntity<T>::new::{{closure}}::h885de5ac95523e66
        +266 ┊ smoldot_light::json_rpc_service::Background<TPlat>::handle_request::{{closure}}::h2face2d057f4dd73
        +197 ┊ alloc::raw_vec::RawVec<T,A>::grow_amortized::h1b03729b761c9426
        -197 ┊ alloc::raw_vec::RawVec<T,A>::grow_amortized::h2f3f1a4b1f718bde
        +164 ┊ wasmi::func::Func::new::ha568b95469d3a4f0
        -164 ┊ wasmi::func::Func::new::hf48befb1ac33ad81
        -161 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold::h0e7601bf80122def
        +161 ┊ <core::iter::adapters::map::Map<I,F> as core::iter::traits::iterator::Iterator>::fold::he8d1a7d06c6db030
        +144 ┊ core::result::Result<T,E>::unwrap::hff2b9d20dddae143
        -144 ┊ smoldot::executor::vm::VirtualMachine::into_prototype::h49d879f4327ded75
        -129 ┊ smoldot::executor::read_only_runtime_host::Inner::run::h00781a00adb20cff
        +115 ┊ smoldot::executor::host::HostVmPrototype::from_module::hc5e95733f3085223
        +113 ┊ core::ops::function::FnOnce::call_once{{vtable.shim}}::h3b1e1e4a5825edbe
         +83 ┊ ... and 141 more.
       +1267 ┊ Σ [161 Total Rows]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant