Fix best_output_block_updated erroneously remaining at false
#2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
commented
Nov 8, 2024
Comment on lines
+918
to
+923
| // Since we change the finalized block, if the output best block is equal to this | ||
| // finalized block, that means it is modified, even though its value might remain | ||
| // at `None`. | ||
| if self.output_best_block_index.is_none() { | ||
| best_output_block_updated = true; | ||
| } |
There was a problem hiding this comment.
That's the bugfix. The rest of the changes are one typo, and clarifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2023
Fix #1941
Work time: 20mn