Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runtime service getting stuck #1874

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fix runtime service getting stuck #1874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e45a1b
Fix runtime service getting stuck
tomaka Jun 17, 2024
2496cb3
PR link and comment tweak
tomaka Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions light-base/src/runtime_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,9 +894,12 @@ async fn run_background<TPlat: PlatformRef>(
WakeUpReason::Notification,
)
}
} else if any_pending_subscription {
} else if any_subscription || any_pending_subscription {
// Only start subscribing to the sync service if there is any pending
// runtime service subscription.
// or active runtime service subscription.
// Note that subscriptions to the runtime service aren't destroyed when the
// sync service subscriptions is lost but when the sync service is
// resubscribed.
WakeUpReason::MustSubscribe
} else {
future::pending().await
Expand Down
4 changes: 4 additions & 0 deletions wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Fixed

- Fix runtime service getting stuck if it was subscribed to before the GrandPa warp sync finishes, and that the runtime of the finalized block in the chain specification is available on the peer-to-peer network. ([#1874](https://github.com/smol-dot/smoldot/pull/1874))

## 2.0.28 - 2024-05-30

### Changed
Expand Down
Loading