Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly accept relayChain and paraId spellings #160

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Feb 10, 2023

Fix #42

I think that serde isn't working as intended, so let's do it differently.

@tomaka tomaka enabled auto-merge February 10, 2023 17:15
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       +8908 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::hbe18de873609fa22
       -6947 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_map::h9041dd7566242c91
       +1750 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::hdadbf8be62f41665
       -1418 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_any::hc89f23a8401b568c
       -1264 ┊ <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct::h6fe23d4154a85cf0
        -740 ┊ <serde::__private::de::content::ContentVisitor as serde::de::Visitor>::visit_map::h4c95274b1ace3ba3
        -711 ┊ <serde::__private::de::FlatMapDeserializer<E> as serde::de::Deserializer>::deserialize_struct::h3e6b02829e170422
        -668 ┊ serde::__private::de::content::ContentDeserializer<E>::deserialize_integer::hd90dbc23b3ab7d74
        -624 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::h8484a33a28c30a95
        +598 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::h1c4a781f212cad5f
        -598 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::h3ce06dd0376bde3c
        +598 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::hae01d0a6e3918b25
        +564 ┊ smoldot::chain_spec::structs::_::<impl serde::de::Deserialize for smoldot::chain_spec::structs::ChainType>::deserialize::h786365b49674ae56
        -564 ┊ smoldot::chain_spec::structs::_::<impl serde::de::Deserialize for smoldot::chain_spec::structs::ChainType>::deserialize::h7feb4c808c15df6e
        -561 ┊ <smoldot::chain_spec::structs::_::<impl serde::de::Deserialize for smoldot::chain_spec::structs::ChainSpecParachain>::deserialize::__FieldVisitor as serde::de::Visitor>::visit_bytes::h98ebfff2f972f7f1
        +541 ┊ smoldot::chain_spec::structs::_::<impl serde::de::Deserialize for smoldot::chain_spec::structs::Genesis>::deserialize::h4b0a570043244266
        -541 ┊ smoldot::chain_spec::structs::_::<impl serde::de::Deserialize for smoldot::chain_spec::structs::Genesis>::deserialize::h5cb2cae2c02fa345
        -524 ┊ <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed::haf6ed7f41e3a65f8
        -501 ┊ <serde::__private::de::FlatStructAccess<E> as serde::de::MapAccess>::next_key_seed::h50382b4e10551d36
        -491 ┊ <smoldot::chain_spec::structs::_::<impl serde::de::Deserialize for smoldot::chain_spec::structs::ClientSpec>::deserialize::__FieldVisitor as serde::de::Visitor>::visit_borrowed_str::hb3d12e5c6cfba45c
       +1466 ┊ ... and 113 more.
       -6521 ┊ Σ [133 Total Rows]

@tomaka tomaka added this pull request to the merge queue Feb 10, 2023
Merged via the queue into smol-dot:main with commit 002019d Feb 10, 2023
@tomaka tomaka deleted the fix-42 branch February 10, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spelling relayChain and paraId not accepted by smoldot
1 participant