Rework runtime service to directly perform runtime calls #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2024
tomaka
added a commit
to tomaka/smoldot
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1524
This PR refactors the runtime call "infrastructure" of the light client.
Beforehand, runtime calls suffered from many issues: the sync service would try to download call proofs multiple times but without giving a guarantee that the call proof is correct, the runtime service would have this awkward runtime access system, and the runtime call code was duplicated a couple of times throughout the node.
This PR fixes all of this by making the runtime service directly sends call proof requests using the network service, and directly execute runtime calls.
The runtime service is now much more clean, and can IMO be considered as having a stable API from now on.