Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaScript error when a JSON-RPC response is generated while a chain is removed #1512

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Fix JavaScript error when a JSON-RPC response is generated while a chain is removed #1512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14cb84e
Fix bug
tomaka Dec 23, 2023
f9b324d
CHANGELOG
tomaka Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions wasm-node/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Fix state mismatch during warp syncing if a peer sends a bad header, justification, or proof. ([#1498](https://github.com/smol-dot/smoldot/pull/1498))
- Fix bugs in various corner cases when decoding and analyzing a Merkle proof. ([#1462](https://github.com/smol-dot/smoldot/pull/1462))
- Fix Merkle proofs being considered as invalid if they contain a storage value that happens to successfully decode as a trie node with an inline child. ([#1504](https://github.com/smol-dot/smoldot/pull/1504))
- Fix crash when using a worker due to race condition when a chain is removed while a JSON-RPC response is generated for it. ([#1512](https://github.com/smol-dot/smoldot/pull/1512))

## 2.0.15 - 2023-12-20

Expand Down
3 changes: 2 additions & 1 deletion wasm-node/javascript/src/internals/remote-instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,10 @@ export async function connectToInstanceServer(config: ConnectConfig): Promise<in
case "json-rpc-response": {
const queue = state.jsonRpcResponses.get(message.chainId);
// The chain might have been removed locally in the past.
if (queue)
if (queue) {
queue.push(message.response);
config.eventCallback({ ty: "json-rpc-responses-non-empty", chainId: message.chainId })
}
return;
}
}
Expand Down
Loading