Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite proof decoding code to not use a separate map #1462

Merged
merged 29 commits into from
Dec 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
0b922bd
Rewrite proof decoding code to not use a separate map
tomaka Dec 9, 2023
3f59d66
Work in progress
tomaka Dec 12, 2023
536d841
Merge branch 'main' into rewrite-proof-decoding
tomaka Dec 21, 2023
ddb672c
Adjust some APIs
tomaka Dec 21, 2023
e28159a
Use strong typing for stack entries
tomaka Dec 21, 2023
ba75a25
Don't decode trie nodes twice when decoding
tomaka Dec 21, 2023
a0fbda1
Work on next_key
tomaka Dec 21, 2023
37e6175
`next_key` is expected to work now
tomaka Dec 21, 2023
265a012
Fix benches
tomaka Dec 21, 2023
a46750f
Give me a break
tomaka Dec 21, 2023
683e3e0
Merge branch 'main' into rewrite-proof-decoding
tomaka Dec 21, 2023
f39dc72
Fix tests compilation
tomaka Dec 21, 2023
559f840
Uncomment now-working test
tomaka Dec 21, 2023
b61325a
Implement trie_node_info
tomaka Dec 21, 2023
f80e764
Reimplement `iter_ordered`
tomaka Dec 21, 2023
bd1ad45
Don't require lifetime on `trie_root_merkle_value`
tomaka Dec 21, 2023
331d753
Update light client
tomaka Dec 21, 2023
0f89ccf
Inline and fix `closest_ancestor_in_proof`
tomaka Dec 21, 2023
1254ae6
Remove empty proof special case
tomaka Dec 21, 2023
d781a46
Improve fmt::Debug for EntryKeyIter
tomaka Dec 21, 2023
9a7e1e5
Bugfix in `next_key`
tomaka Dec 21, 2023
8f169af
Uncomment failing test
tomaka Dec 21, 2023
ea7564f
CHANGELOG
tomaka Dec 21, 2023
230042a
Fix warnings
tomaka Dec 21, 2023
6278aa5
Typo
tomaka Dec 21, 2023
378ae19
Fix children with nibble `e` being skipped
tomaka Dec 21, 2023
08472b5
Stupidest typo
tomaka Dec 21, 2023
e14ad0f
Add some TODOs
tomaka Dec 21, 2023
2641095
Small revert in runtime_service
tomaka Dec 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Uncomment now-working test
tomaka committed Dec 21, 2023

Verified

This commit was signed with the committer’s verified signature.
ovflowd Claudio W
commit 559f8409c7de7eb87df2723fd019eef614d79ba4
5 changes: 2 additions & 3 deletions lib/src/trie/proof_decode.rs
Original file line number Diff line number Diff line change
@@ -1869,8 +1869,7 @@ mod tests {
][..]
);

// TODO: this check doesn't pass, even though I think it should, might be a bug in the implementation
/*assert!(matches!(
assert!(matches!(
dbg!(decoded.closest_descendant_merkle_value(
EXAMPLE_PROOF_STATE_ROOT,
[
@@ -1879,7 +1878,7 @@ mod tests {
].into_iter()
)),
Err(super::IncompleteProofError())
));*/
));

assert!(decoded
.closest_descendant_merkle_value(
Loading