Check block requests response in higher level code instead #1238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the
SyncService::blocks_query
function downloads the block from a peer then verifies whether the body matches the header.This has two issues:
In #1200 I'm planning to remove this check.
This PR is a preliminary change to make the high-level code verify the block headers and bodies, instead of the low-level code.
Note that the syncing code already verifies whether headers in responses match the expected hash. As for bodies, I've added a TODO in the optimistic syncing. Since this doesn't concern the light client it isn't critical.
A side change is that I realize that
chain_getBlock
directly returns the justifications downloaded from the network without verifying them. I've removed this and mentioned it in the CHANGELOG.