Use correct multihash algorithm code for WebRTC addresses #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arf, thank you! Asking by curiosity: have you been testing WebRTC? Unfortunately it's not unlikely that smoldot's code has been broken during a refactoring (as this PR proves), because testing WebRTC is pretty cumbersome at the moment. |
tomaka
approved these changes
Aug 15, 2023
|
Yeah I have started working on the code and have found couple of problems. I'll report them (along with bug fixes if I can fix them) as I make progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct code for SHA256 multihash is
0x12: https://github.com/multiformats/rust-multihash/blob/452a933396adcd5915c53563d5017df76ae3ec26/codetable/src/lib.rs#L44-L47