Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainHead_v1_call always yields operationInaccessible events for DryRunApi_dry_run_call #2035

Closed
josepot opened this issue Nov 17, 2024 · 16 comments · Fixed by #2037
Closed

Comments

@josepot
Copy link
Contributor

josepot commented Nov 17, 2024

The DryRunApi_dry_run_call runtime-API always yields an operationInaccessible event, making it unusable with smoldot.

This runtime-api is very useful for calculating the XCM delivery fees and for many other use-cases.

This issue is preventing the following PR from being merged.

I have created the following repo to reproduce this issue, using this code (the exact same code works with a WebSocket provider).

The logs that I captured after running that code:

I'm more than willing to test this problem with a custom build of smoldot and/or to provide any other assistance to get to the bottom of this issue.

tomaka added a commit to tomaka/smoldot that referenced this issue Nov 18, 2024
@tomaka
Copy link
Contributor

tomaka commented Nov 18, 2024

Here's a branch that you can please use: https://github.com/tomaka/smoldot/tree/debug-2035
It will generate the logs that interest me.

@josepot
Copy link
Contributor Author

josepot commented Nov 18, 2024

The updated logs that I obtained from the build of the custom branch:

tomaka added a commit to tomaka/smoldot that referenced this issue Nov 18, 2024
@tomaka tomaka mentioned this issue Nov 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 18, 2024
* Fix #2035

* CHANGELOG

* Rustfmt

* I'm an idiot, there already was a `tests` module

* Remove dbg!()
@0xKheops
Copy link

Thank you so much to both of you for your help with this problem, and for solving it so fast!

@josepot
Copy link
Contributor Author

josepot commented Nov 18, 2024

Unfortunately, the issue persists with the latest version of smoldot (2.0.32). So, I think that this issue was prematurely closed.

The logs:

@tomaka
Copy link
Contributor

tomaka commented Nov 18, 2024

There's more than one bug, then. I've updated my branch above.

@tomaka tomaka reopened this Nov 18, 2024
@josepot
Copy link
Contributor Author

josepot commented Nov 18, 2024

New logs with the custom build:

tomaka added a commit to tomaka/smoldot that referenced this issue Nov 18, 2024
@tomaka
Copy link
Contributor

tomaka commented Nov 18, 2024

Before I release a version, could you try again with #2039 ? (or with the main branch, as I'm going to merge that PR no matter what)

I've also already merged #2039 onto the branch above in case it fails again.

github-merge-queue bot pushed a commit that referenced this issue Nov 18, 2024
* Add repro case

* Fix #2035 again

* CHANGELOG
@josepot
Copy link
Contributor Author

josepot commented Nov 18, 2024

Before I release a version, could you try again with #2039 ? (or with the main branch, as I'm going to merge that PR no matter what)

I've also already merged #2039 onto the branch above in case it fails again.

Still not working, the logs (with the custom build):

@tomaka
Copy link
Contributor

tomaka commented Nov 19, 2024

Opened #2041 and updated the branch above.

@josepot
Copy link
Contributor Author

josepot commented Nov 19, 2024

Opened #2041 and updated the branch above.

Third time's the charm!!! It works! Thanks @tomaka !

@0xKheops
Copy link

Thanks!

@tomaka
Copy link
Contributor

tomaka commented Nov 19, 2024

I'm afk for a few hours now, but I'll publish a version later today.

github-merge-queue bot pushed a commit that referenced this issue Nov 19, 2024
* Add repro

* Fix first issue

* Fix second issue

* CHANGELOG
@tomaka tomaka closed this as completed Nov 19, 2024
@josepot
Copy link
Contributor Author

josepot commented Nov 19, 2024

Unfortunately, we just noticed that this issue still exists with kusama 😞

EDIT:

For some reason the build from the branch debug-2035 is not producing logs against kusama 🤔

@tomaka
Copy link
Contributor

tomaka commented Nov 20, 2024

The debug-2035 branch is additional logs about a specific bug. I need the generic logs again.

@tomaka tomaka reopened this Nov 20, 2024
@josepot
Copy link
Contributor Author

josepot commented Nov 20, 2024

The debug-2035 branch is additional logs about a specific bug. I need the generic logs again.

here you go, generic logs of the same code as before but running it against the Kusama relay-chain and using the latest main on smoldot:

@tomaka
Copy link
Contributor

tomaka commented Nov 20, 2024

This new problem is the same as #1985, so I'm going to close this one again.

@tomaka tomaka closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants