Fix mismatch between legacy and new transactions API (#677)

* Fix mismatch between legacy and new transactions API * PR link * Add `erroneously` in CHANGELOG
smol-dot · Jun 6, 2023 · abad638 · abad638
1 parent 154d52d
commit abad638
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/light-base/src/json_rpc_service/background/transactions.rs b/light-base/src/json_rpc_service/background/transactions.rs
@@ -269,7 +269,7 @@ impl<TPlat: PlatformRef> Background<TPlat> {
                     };
 
                     let update = match (status_update, is_legacy) {
-                        (transactions_service::TransactionStatus::Broadcast(peers), false) => {
+                        (transactions_service::TransactionStatus::Broadcast(peers), true) => {
                             methods::ServerToClient::author_extrinsicUpdate {
                                 subscription: (&subscription_id).into(),
                                 result: methods::TransactionStatus::Broadcast(
@@ -278,7 +278,7 @@ impl<TPlat: PlatformRef> Background<TPlat> {
                             }
                             .to_json_call_object_parameters(None)
                         }
-                        (transactions_service::TransactionStatus::Broadcast(peers), true) => {
+                        (transactions_service::TransactionStatus::Broadcast(peers), false) => {
                             num_broadcasted_peers += peers.len();
                             methods::ServerToClient::transaction_unstable_watchEvent {
                                 subscription: (&subscription_id).into(),

diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixed
+
+- Fix `author_submitAndWatchExtrinsic` erroneously generating `transaction_unstable_watchEvent` notifications, and `transaction_unstable_submitAndWatch` erroneously generating `author_extrinsicUpdate` notifications. ([#677](https://github.com/smol-dot/smoldot/pull/677))
+
 ## 1.0.8 - 2023-06-05
 
 ### Changed