Adjust naming of allHead notifications (#227)

* Adjust naming of `allHead` notifications * CHANGELOG entry --------- Co-authored-by: Pierre Krieger <[email protected]>
smol-dot · Feb 24, 2023 · 890f31a · 890f31a
1 parent 2bd5965
commit 890f31a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/lib/src/json_rpc/methods.rs b/lib/src/json_rpc/methods.rs
@@ -503,6 +503,7 @@ define_methods! {
     author_extrinsicUpdate(subscription: Cow<'a, str>, result: TransactionStatus) -> (),
     chain_finalizedHead(subscription: Cow<'a, str>, result: Header) -> (),
     chain_newHead(subscription: Cow<'a, str>, result: Header) -> (),
+    chain_allHead(subscription: Cow<'a, str>, result: Header) -> (),
     state_runtimeVersion(subscription: Cow<'a, str>, result: Option<RuntimeVersion<'a>>) -> (), // TODO: the Option is a custom addition
     state_storage(subscription: Cow<'a, str>, result: StorageChangeSet) -> (),
 

diff --git a/light-base/src/json_rpc_service/state_chain.rs b/light-base/src/json_rpc_service/state_chain.rs
@@ -490,7 +490,7 @@ impl<TPlat: Platform> Background<TPlat> {
                                     .requests_subscriptions
                                     .try_push_notification(
                                         &state_machine_subscription,
-                                        methods::ServerToClient::chain_newHead {
+                                        methods::ServerToClient::chain_allHead {
                                             subscription: (&subscription_id).into(),
                                             result: header,
                                         }

diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md
@@ -5,6 +5,7 @@
 ## Fixed
 
 - Fix panic when the input data of a Wasm function call is larger than a Wasm page. ([#218](https://github.com/smol-dot/smoldot/pull/218))
+- Subscriptions to the `chain_subscribeAllHeads` JSON-RPC function now generate notifications named `chain_allHead`, like in Substrate. They were erroneously named `chain_newHead`. ([#227](https://github.com/smol-dot/smoldot/pull/227))
 
 ## 0.7.12 - 2022-02-22