No longer cargo publish dry-run the light and full nodes (#1014)

smol-dot · Aug 10, 2023 · 847be4a · 847be4a
1 parent ab176ac
commit 847be4a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -250,10 +250,10 @@ jobs:
       - uses: actions/checkout@v3
       - run: cargo publish --dry-run --locked
         working-directory: ./lib
-      - run: cargo publish --dry-run --locked
-        working-directory: ./light-base
-      - run: cargo publish --dry-run --locked
-        working-directory: ./full-node
+        # Note that no dry run is performed for the crates that have dependencies towards the
+        # library, as `cargo publish --dry-run` tries to build them against the version on
+        # `crates.io`, which causes build failures if its public API has changed.
+        # TODO: is there a way to solve that? ^
       - run: cargo login ${{ secrets.CRATES_IO_TOKEN }}
         if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
       - run: cargo publish --no-verify