Fix author_extrinsicUpdate notifications being PascalCased (#611)

* Fix `author_extrinsicUpdate` notifications being PascalCased * PR link
smol-dot · May 25, 2023 · 54acbdb · 54acbdb
1 parent 9b8c00e
commit 54acbdb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/src/json_rpc/methods.rs b/lib/src/json_rpc/methods.rs
@@ -1062,15 +1062,25 @@ pub enum SystemPeerRole {
 
 #[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
 pub enum TransactionStatus {
+    #[serde(rename = "future")]
     Future,
+    #[serde(rename = "ready")]
     Ready,
+    #[serde(rename = "broadcast")]
     Broadcast(Vec<String>), // Base58 PeerIds  // TODO: stronger typing
+    #[serde(rename = "inBlock")]
     InBlock(HashHexString),
+    #[serde(rename = "retracted")]
     Retracted(HashHexString),
+    #[serde(rename = "finalityTimeout")]
     FinalityTimeout(HashHexString),
+    #[serde(rename = "finalized")]
     Finalized(HashHexString),
+    #[serde(rename = "usurped")]
     Usurped(HashHexString),
+    #[serde(rename = "dropped")]
     Dropped,
+    #[serde(rename = "invalid")]
     Invalid,
 }
 

diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md
@@ -7,6 +7,7 @@
 - When a runtime contains a `runtime_apis` custom section but no `runtime_version` custom section, or vice-versa, smoldot now falls back to calling `Core_version`. ([#607](https://github.com/smol-dot/smoldot/pull/607))
 - Fix panic when the checkpoint in the chain specification is invalid, which can normally only happen if the checkpoint was modified manually. ([#603](https://github.com/smol-dot/smoldot/pull/603))
 - Fix panic when the checkpoint in the chain specification contains zero or one Babe epochs, which can happen if the checkpoint was generated before any block was authored. ([#603](https://github.com/smol-dot/smoldot/pull/603))
+- The notifications generated by the `author_extrinsicUpdate` JSON-RPC function are now properly camelCased (`future`, `ready`, `broadcast`, `inBlock`, `retracted`, `finalityTimeout`, `finalized`, `usurped`, `dropped`, and `invalid`). They were previously PascalCased (`Future`, `Ready`, `Broadcast`, `InBlock`, `Retracted`, `FinalityTimeout`, `Finalized`, `Usurped`, `Dropped`, and `Invalid`). ([#611](https://github.com/smol-dot/smoldot/pull/611))
 
 ## 1.0.6 - 2023-05-09