Fix runtime service getting stuck (#1874)

* Fix runtime service getting stuck * PR link and comment tweak
smol-dot · Jun 17, 2024 · 464bf01 · 464bf01
1 parent 91f4bc1
commit 464bf01
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/light-base/src/runtime_service.rs b/light-base/src/runtime_service.rs
@@ -894,9 +894,12 @@ async fn run_background<TPlat: PlatformRef>(
                             WakeUpReason::Notification,
                         )
                     }
-                } else if any_pending_subscription {
+                } else if any_subscription || any_pending_subscription {
                     // Only start subscribing to the sync service if there is any pending
-                    // runtime service subscription.
+                    // or active runtime service subscription.
+                    // Note that subscriptions to the runtime service aren't destroyed when the
+                    // sync service subscriptions is lost but when the sync service is
+                    // resubscribed.
                     WakeUpReason::MustSubscribe
                 } else {
                     future::pending().await

diff --git a/wasm-node/CHANGELOG.md b/wasm-node/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixed
+
+- Fix runtime service getting stuck if it was subscribed to before the GrandPa warp sync finishes, and that the runtime of the finalized block in the chain specification is available on the peer-to-peer network. ([#1874](https://github.com/smol-dot/smoldot/pull/1874))
+
 ## 2.0.28 - 2024-05-30
 
 ### Changed