Astro - Make push more readable

smastrom · Apr 14, 2024 · 9f65f6e · 9f65f6e
1 parent 7ed383f
commit 9f65f6e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/packages/notivue/astro/Notivue.vue b/packages/notivue/astro/Notivue.vue
@@ -17,7 +17,7 @@ function onPush(e: CustomEvent<PushAstroEvent>) {
    // Create the notification as usual
    const notification = push[e.detail.type](e.detail)
 
-   // Dispatch the push result
+   // Dispatch the result
    window.dispatchEvent(
       new CustomEvent(e.detail.resultEventName, {
          detail: notification,

diff --git a/packages/notivue/astro/push.ts b/packages/notivue/astro/push.ts
@@ -8,20 +8,20 @@ export function pushEvent<T extends Omit<PushAstroEvent, 'resultEventName'>>(
 ): MaybeAstroPushPromiseReturn<T> {
    eventId++
 
-   // Listen for the result of the notification that will be created by NotivueAstro...
+   // Prepare to listen for the result of the notification that will be created by NotivueAstro...
    let pushResult = {} as MaybeAstroPushPromiseReturn<T>
    const resultEventName = `notivue:id:${eventId}`
 
    // ...upon receival, save the result and remove the listener
-   window.addEventListener(resultEventName, saveResult as EventListener, {
-      once: true,
-   })
-
-   function saveResult(e: CustomEvent<MaybeAstroPushPromiseReturn<T>>) {
-      pushResult = e.detail
-   }
+   window.addEventListener(
+      resultEventName,
+      ((e: CustomEvent<MaybeAstroPushPromiseReturn<T>>) => {
+         pushResult = e.detail
+      }) as EventListener,
+      { once: true }
+   )
 
-   // Dispatch the incoming push options to the receiver to create the notification
+   // Dispatch the incoming push options to NotivueAstro to create the notification
    window.dispatchEvent(
       new CustomEvent('notivue:push', {
          detail: {
@@ -32,6 +32,7 @@ export function pushEvent<T extends Omit<PushAstroEvent, 'resultEventName'>>(
       })
    )
 
+   // Return the result
    return pushResult
 }