Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in VirtinkCluster.Spec.ControlPlaneServiceType #13

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix: Fix typo in VirtinkCluster.Spec.ControlPlaneServiceType #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1beta1/virtinkcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type VirtinkClusterSpec struct {
// ControlPlaneServiceType can be used to modify type of service that fronts the control plane nodes to handle the
// api-server traffic (port 6443). This field is optional, by default control plane nodes will use a service
// of type ClusterIP, which will make workload cluster only accessible within the same cluster.
ControlPlaneServiceType *corev1.ServiceType `json:"conrolPlaneServiceType,omitempty"`
ControlPlaneServiceType *corev1.ServiceType `json:"controlPlaneServiceType,omitempty"`

// InfraClusterSecretRef is a reference to a secret with a kubeconfig for external cluster used for infra.
InfraClusterSecretRef *corev1.ObjectReference `json:"infraClusterSecretRef,omitempty"`
Expand Down
14 changes: 7 additions & 7 deletions config/crd/bases/infrastructure.cluster.x-k8s.io_virtinkclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,6 @@ spec:
spec:
description: VirtinkClusterSpec defines the desired state of VirtinkCluster
properties:
conrolPlaneServiceType:
description: ControlPlaneServiceType can be used to modify type of
service that fronts the control plane nodes to handle the api-server
traffic (port 6443). This field is optional, by default control
plane nodes will use a service of type ClusterIP, which will make
workload cluster only accessible within the same cluster.
type: string
controlPlaneEndpoint:
description: ControlPlaneEndpoint represents the endpoint used to
communicate with the control plane.
Expand All @@ -67,6 +60,13 @@ spec:
- host
- port
type: object
controlPlaneServiceType:
description: ControlPlaneServiceType can be used to modify type of
service that fronts the control plane nodes to handle the api-server
traffic (port 6443). This field is optional, by default control
plane nodes will use a service of type ClusterIP, which will make
workload cluster only accessible within the same cluster.
type: string
infraClusterSecretRef:
description: InfraClusterSecretRef is a reference to a secret with
a kubeconfig for external cluster used for infra.
Expand Down
2 changes: 1 addition & 1 deletion templates/cluster-template-internal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ kind: VirtinkCluster
metadata:
name: "${CLUSTER_NAME}"
spec:
conrolPlaneServiceType: "${VIRTINK_CONTROL_PLANE_SERVICE_TYPE:=NodePort}"
controlPlaneServiceType: "${VIRTINK_CONTROL_PLANE_SERVICE_TYPE:=NodePort}"
---
apiVersion: controlplane.cluster.x-k8s.io/v1beta1
kind: KubeadmControlPlane
Expand Down
2 changes: 1 addition & 1 deletion templates/cluster-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ kind: VirtinkCluster
metadata:
name: "${CLUSTER_NAME}"
spec:
conrolPlaneServiceType: "${VIRTINK_CONTROL_PLANE_SERVICE_TYPE:=NodePort}"
controlPlaneServiceType: "${VIRTINK_CONTROL_PLANE_SERVICE_TYPE:=NodePort}"
infraClusterSecretRef:
name: "${VIRTINK_INFRA_CLUSTER_SECRET_NAME}"
namespace: "${VIRTINK_INFRA_CLUSTER_SECRET_NAMESPACE}"
Expand Down